[lld] [lld][ELF][AArch64] Support `R_AARCH64_GOT_LD_PREL19` relocation (PR #89592)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 05:40:24 PDT 2024


https://github.com/smithp35 commented:

Code and test changes LGTM. I guess we've not had anyone actively try out the tiny code-model with either -fpie or -fpic with LLD yet as this relocation will be very common.

As far as I can tell the only difference between the test case in aarch64-got-relocations.s and aarch64-fpic-got.s is the type of the destination symbol. Adding the tiny code-model to aarch64-got-relocations.s would be a nice to have, but I don't think it would be adding anything significant.

The only thing that I can think of that we could possibly do is make a human-readable error message when the tiny-code model size limits are exceeded rather than the likely relocation out of range errors we'll get today. However I think that's outside the scope of this patch.

https://github.com/llvm/llvm-project/pull/89592


More information about the llvm-commits mailing list