[llvm] 2e7bd22 - [NFC] Fix comments in PassBuilder functions (#89513)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 05:19:29 PDT 2024


Author: Ellis Hoag
Date: 2024-04-22T07:19:25-05:00
New Revision: 2e7bd22b37cd6f4e266d0512220b983144d9be0b

URL: https://github.com/llvm/llvm-project/commit/2e7bd22b37cd6f4e266d0512220b983144d9be0b
DIFF: https://github.com/llvm/llvm-project/commit/2e7bd22b37cd6f4e266d0512220b983144d9be0b.diff

LOG: [NFC] Fix comments in PassBuilder functions (#89513)

The original comments mention `addPreLinkLTODefaultPipeline`, but I
could not find any functions with this name, even in
https://reviews.llvm.org/D33540
(8b3be4e59d861130746206e41ae42c918bc165df) where this comment was added.
I assume they meant to refer to `buildThinLTOPreLinkDefaultPipeline` and
`buildLTOPreLinkDefaultPipeline` and so this patch uses them.

Added: 
    

Modified: 
    llvm/include/llvm/Passes/PassBuilder.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Passes/PassBuilder.h b/llvm/include/llvm/Passes/PassBuilder.h
index c8f643452bb158..9b4da1c466f57d 100644
--- a/llvm/include/llvm/Passes/PassBuilder.h
+++ b/llvm/include/llvm/Passes/PassBuilder.h
@@ -264,12 +264,12 @@ class PassBuilder {
   /// the LTO run.
   ModulePassManager buildThinLTOPreLinkDefaultPipeline(OptimizationLevel Level);
 
-  /// Build an ThinLTO default optimization pipeline to a pass manager.
+  /// Build a ThinLTO default optimization pipeline to a pass manager.
   ///
   /// This provides a good default optimization pipeline for link-time
   /// optimization and code generation. It is particularly tuned to fit well
   /// when IR coming into the LTO phase was first run through \c
-  /// addPreLinkLTODefaultPipeline, and the two coordinate closely.
+  /// buildThinLTOPreLinkDefaultPipeline, and the two coordinate closely.
   ModulePassManager
   buildThinLTODefaultPipeline(OptimizationLevel Level,
                               const ModuleSummaryIndex *ImportSummary);
@@ -288,7 +288,7 @@ class PassBuilder {
   /// This provides a good default optimization pipeline for link-time
   /// optimization and code generation. It is particularly tuned to fit well
   /// when IR coming into the LTO phase was first run through \c
-  /// addPreLinkLTODefaultPipeline, and the two coordinate closely.
+  /// buildLTOPreLinkDefaultPipeline, and the two coordinate closely.
   ModulePassManager buildLTODefaultPipeline(OptimizationLevel Level,
                                             ModuleSummaryIndex *ExportSummary);
 


        


More information about the llvm-commits mailing list