[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

Akash Banerjee via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 22 04:09:03 PDT 2024


TIFitis wrote:

> This patch is huge, and just skimming over it shows various places that could be split off, and others that should not make it to the review stage (commented out code). Please update.

Hi, thanks for talking the time out to review the patch.

I've addressed the comments you made and also fixed the build issues. It now builds cleanly again and passes all checks.

I'm not sure however on how to split the patch, as we definitely need all the pieces to pass the CI tests. I hope it isn't too much of a burden to review the patch.

Thanks.

https://github.com/llvm/llvm-project/pull/80343


More information about the llvm-commits mailing list