[llvm] Create a CharSetConverter class with both iconv and icu support (PR #74516)

via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 13:41:06 PDT 2024


================
@@ -295,6 +296,14 @@ add_llvm_component_library(LLVMSupport
   Demangle
   )
 
+# Link icu library if it is an external library.
+if(ICU_FOUND)
+  target_link_libraries(LLVMSupport
+  PRIVATE
+  ${ICU_LIBRARIES}
----------------
cor3ntin wrote:

This is the license for Unicode data files which is separate from ICU.

ICU is afaik under MIT license.
My understanding is that we do not need to include the license because we do not ship the software nor do we modify it, as @efriedma-quic  said.

However IANAL so I cannot make a definitive statement :)

https://github.com/llvm/llvm-project/pull/74516


More information about the llvm-commits mailing list