[llvm] Create a CharSetConverter class with both iconv and icu support (PR #74516)

Abhina Sree via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 11:57:21 PDT 2024


================
@@ -295,6 +296,14 @@ add_llvm_component_library(LLVMSupport
   Demangle
   )
 
+# Link icu library if it is an external library.
+if(ICU_FOUND)
+  target_link_libraries(LLVMSupport
+  PRIVATE
+  ${ICU_LIBRARIES}
----------------
abhina-sree wrote:

That was my initial understanding. @cor3ntin I think you added similar license text here in the past for Unicode https://github.com/llvm/llvm-project/blob/main/llvm/lib/Support/UnicodeNameToCodepointGenerated.cpp#L17. Would you be able to advise on whether we require the license text for this specific case? Thanks

https://github.com/llvm/llvm-project/pull/74516


More information about the llvm-commits mailing list