[llvm] [Inliner] Propagate callee argument memory access attributes before inlining (PR #89024)

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 03:40:46 PDT 2024


nhaehnle wrote:

The change looks correct to me, but I wonder where this is useful and what the benefit/compile-time tradeoff is?

Propagating these attributes from the function definition itself to its body could and maybe should happen elsewhere: once per definition instead of each time the inliner runs. And what's the scenario in which the attributes are added on the `call` instruction itself?

I assume there's some reason, otherwise you wouldn't have posted this PR, but I'd still like to understand it better because it isn't obvious to me.

https://github.com/llvm/llvm-project/pull/89024


More information about the llvm-commits mailing list