dwblaikie wrote: Looking pretty good to me - few things here and there, and the test coverage as mentioned. Perhaps @MaskRay can check me on the feedback, so you're not going back and forth between the two of us. https://github.com/llvm/llvm-project/pull/86508