[lld] [lld][ELF] Add --debug-names to create merged .debug_names. (PR #86508)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 16:38:17 PDT 2024


dwblaikie wrote:

Per the LLVM guidelines, please don't force-push reviews ( https://llvm.org/docs/GitHub.html#updating-pull-requests ) - the force push yesterday removed all the previous commits in this PR and replaced them with a new stack - so now it's not possible to see some of the code that previous comments related to, so far as I can tell. (though some comments do still seem to line up with previous commits, so I'm not entirely sure what state this is all in)

(I understand you were trying to fix some attribution issues - and that git and github are complex/hard to get right - but a note for the future, at least. I don't think there's anything that can be done to fix this case/recover the previous commits, etc - it might've been possible to change only some of the later commits, without rewriting the whole stack of commits in this PR, maybe)

I'll take a look at the current state, in any case.

https://github.com/llvm/llvm-project/pull/86508


More information about the llvm-commits mailing list