[llvm] [AArch64] SimplifyDemandedBitsForTargetNode - add AArch64ISD::BICi handling (PR #76644)

David Green via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 6 07:00:39 PDT 2024


https://github.com/davemgreen commented:

> AArch64SelectionDAGTest.cpp

I see what you mean, with them being specified in AArch64ISelLowering.h. I think so long as this is tested and looks sensible it should be OK (the C++ tests just make it easier to write more comprehensive tests).

If you can remove the unused variable then this LGTM too.

https://github.com/llvm/llvm-project/pull/76644


More information about the llvm-commits mailing list