[llvm] [Object][COFF][NFC] Don't use inline function for COFFImportFile::printSymbolName. (PR #87195)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 11:21:18 PDT 2024


dwblaikie wrote:

This was sent for review but review wasn't completed? (if it was not intended for review, only for precommit automated testing, please mark such changes in the future as `skip-precommit-approval` label ( https://llvm.org/docs/CodeReview.html#code-review-workflow ))

But also this sort of change seems suspect. It sounds like some dependency/layering isn't properly described? It shouldn't be necessary/correct/make any difference to move implementations between headers and implementation files if we've described the dependencies correctly - and if we haven't, we should fix that, because living in a world where code can't move freely between header and cpp file is a maintenance problem.

https://github.com/llvm/llvm-project/pull/87195


More information about the llvm-commits mailing list