[llvm] [MemProf] Remove empty edges once after cloning (PR #85320)

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 19:10:28 PDT 2024


================
@@ -306,7 +306,7 @@ class CallsiteContextGraph {
     // True if this node was effectively removed from the graph, in which case
     // its context id set, caller edges, and callee edges should all be empty.
     bool isRemoved() const {
-      assert(ContextIds.empty() ==
+      assert(!ContextIds.empty() ||
----------------
snehasish wrote:

I dont think there will be an extra check. With clang for non-assert builds (where NDEBUG is defined) the IR has an empty basic block [1] which should get optimized away in the generated code.

[1] https://godbolt.org/z/r5fceqeTK 

https://github.com/llvm/llvm-project/pull/85320


More information about the llvm-commits mailing list