[llvm] [MemProf] Remove empty edges once after cloning (PR #85320)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 17:15:25 PDT 2024


================
@@ -306,7 +306,7 @@ class CallsiteContextGraph {
     // True if this node was effectively removed from the graph, in which case
     // its context id set, caller edges, and callee edges should all be empty.
     bool isRemoved() const {
-      assert(ContextIds.empty() ==
+      assert(!ContextIds.empty() ||
----------------
teresajohnson wrote:

It is equivalent, it just means an extra check that is executed unnecessarily. Although hopefully the compiler would common it with the check on the return?

https://github.com/llvm/llvm-project/pull/85320


More information about the llvm-commits mailing list