[llvm] [RISCV] Add scheduling information for SiFive VCIX (PR #86093)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 21 16:54:56 PDT 2024


michaelmaitland wrote:

> One concern is that: I prefer to restrict vendors' scheduling infos to their own RISCVSchedXXX.td via mechanisms like InstRW, SchedVariant, etc.

I am in agreement with you with what I prefer. 

What would be really nice is that each SchedModel does not have to say what is Unsupported and instead if it is not explicitly written in the model, then it is unsupported. We have the current case where every extension added to the compiler forces someone to specify that it is unsupported in every scheduler model.

WRT to `InstRW`, I am concerned that there could be situations where it gets out of hand having to name every instruction. I think this is harder to maintain compared to writing `UnsupportedXXX` in each model. For small number of instructions I am okay to look the other way.

I would be okay to let the approach taken in this PR through and have us explore how to fix this for unsupported extensions in general. WDYT @wangpc-pp?

https://github.com/llvm/llvm-project/pull/86093


More information about the llvm-commits mailing list