[llvm] [InstCombine] Fold (X / C) < X and (X >> C) < X into X > 0 (PR #85555)

via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 12:29:48 PDT 2024


Poseydon42 wrote:

Yeah, that merge was an accident, I'll remove it before pushing the most recent changes. It seems to me like handling `ashr` would just unnecessarily increase the complexity of the code without providing significant benefit, so I'll omit it. The only question I have now is whether I should add tests for all three instructions I'm working with and all 10 (or 6) comparison predicates, making it 26 tests in total, which, together with negative tests, will bring it closer to 30, or should I simply test 2-3 predicates for each of the three instructions?

https://github.com/llvm/llvm-project/pull/85555


More information about the llvm-commits mailing list