[llvm] [X86] Add missing immediate qualifier to the (V)CMPSS/D instructions (PR #84496)

via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 07:17:36 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff ce683273aa3dbdd7bce2168c29b1a7652ce73608 9872cae51f75f769b6433ba0d3dae48b6e623465 -- llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp llvm/lib/Target/X86/MCTargetDesc/X86EncodingOptimization.cpp llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp llvm/lib/Target/X86/X86FastISel.cpp llvm/lib/Target/X86/X86InstrInfo.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
index 33104524c5..55cb27b530 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp
@@ -89,12 +89,18 @@ bool X86ATTInstPrinter::printVecCompareInstr(const MCInst *MI,
   // Custom print the vector compare instructions to get the immediate
   // translated into the mnemonic.
   switch (MI->getOpcode()) {
-  case X86::CMPPDrmi:     case X86::CMPPDrri:
-  case X86::CMPPSrmi:     case X86::CMPPSrri:
-  case X86::CMPSDrmi:     case X86::CMPSDrri:
-  case X86::CMPSDrmi_Int: case X86::CMPSDrri_Int:
-  case X86::CMPSSrmi:     case X86::CMPSSrri:
-  case X86::CMPSSrmi_Int: case X86::CMPSSrri_Int:
+  case X86::CMPPDrmi:
+  case X86::CMPPDrri:
+  case X86::CMPPSrmi:
+  case X86::CMPPSrri:
+  case X86::CMPSDrmi:
+  case X86::CMPSDrri:
+  case X86::CMPSDrmi_Int:
+  case X86::CMPSDrri_Int:
+  case X86::CMPSSrmi:
+  case X86::CMPSSrri:
+  case X86::CMPSSrmi_Int:
+  case X86::CMPSSrri_Int:
     if (Imm >= 0 && Imm <= 7) {
       OS << '\t';
       printCMPMnemonic(MI, /*IsVCMP*/false, OS);
@@ -117,56 +123,106 @@ bool X86ATTInstPrinter::printVecCompareInstr(const MCInst *MI,
     }
     break;
 
-  case X86::VCMPPDrmi:       case X86::VCMPPDrri:
-  case X86::VCMPPDYrmi:      case X86::VCMPPDYrri:
-  case X86::VCMPPDZ128rmi:   case X86::VCMPPDZ128rri:
-  case X86::VCMPPDZ256rmi:   case X86::VCMPPDZ256rri:
-  case X86::VCMPPDZrmi:      case X86::VCMPPDZrri:
-  case X86::VCMPPSrmi:       case X86::VCMPPSrri:
-  case X86::VCMPPSYrmi:      case X86::VCMPPSYrri:
-  case X86::VCMPPSZ128rmi:   case X86::VCMPPSZ128rri:
-  case X86::VCMPPSZ256rmi:   case X86::VCMPPSZ256rri:
-  case X86::VCMPPSZrmi:      case X86::VCMPPSZrri:
-  case X86::VCMPSDrmi:       case X86::VCMPSDrri:
-  case X86::VCMPSDZrmi:      case X86::VCMPSDZrri:
-  case X86::VCMPSDrmi_Int:   case X86::VCMPSDrri_Int:
-  case X86::VCMPSDZrmi_Int:  case X86::VCMPSDZrri_Int:
-  case X86::VCMPSSrmi:       case X86::VCMPSSrri:
-  case X86::VCMPSSZrmi:      case X86::VCMPSSZrri:
-  case X86::VCMPSSrmi_Int:   case X86::VCMPSSrri_Int:
-  case X86::VCMPSSZrmi_Int:  case X86::VCMPSSZrri_Int:
-  case X86::VCMPPDZ128rmik:  case X86::VCMPPDZ128rrik:
-  case X86::VCMPPDZ256rmik:  case X86::VCMPPDZ256rrik:
-  case X86::VCMPPDZrmik:     case X86::VCMPPDZrrik:
-  case X86::VCMPPSZ128rmik:  case X86::VCMPPSZ128rrik:
-  case X86::VCMPPSZ256rmik:  case X86::VCMPPSZ256rrik:
-  case X86::VCMPPSZrmik:     case X86::VCMPPSZrrik:
-  case X86::VCMPSDZrmi_Intk: case X86::VCMPSDZrri_Intk:
-  case X86::VCMPSSZrmi_Intk: case X86::VCMPSSZrri_Intk:
-  case X86::VCMPPDZ128rmbi:  case X86::VCMPPDZ128rmbik:
-  case X86::VCMPPDZ256rmbi:  case X86::VCMPPDZ256rmbik:
-  case X86::VCMPPDZrmbi:     case X86::VCMPPDZrmbik:
-  case X86::VCMPPSZ128rmbi:  case X86::VCMPPSZ128rmbik:
-  case X86::VCMPPSZ256rmbi:  case X86::VCMPPSZ256rmbik:
-  case X86::VCMPPSZrmbi:     case X86::VCMPPSZrmbik:
-  case X86::VCMPPDZrrib:     case X86::VCMPPDZrribk:
-  case X86::VCMPPSZrrib:     case X86::VCMPPSZrribk:
-  case X86::VCMPSDZrrib_Int: case X86::VCMPSDZrrib_Intk:
-  case X86::VCMPSSZrrib_Int: case X86::VCMPSSZrrib_Intk:
-  case X86::VCMPPHZ128rmi:   case X86::VCMPPHZ128rri:
-  case X86::VCMPPHZ256rmi:   case X86::VCMPPHZ256rri:
-  case X86::VCMPPHZrmi:      case X86::VCMPPHZrri:
-  case X86::VCMPSHZrmi:      case X86::VCMPSHZrri:
-  case X86::VCMPSHZrmi_Int:  case X86::VCMPSHZrri_Int:
-  case X86::VCMPPHZ128rmik:  case X86::VCMPPHZ128rrik:
-  case X86::VCMPPHZ256rmik:  case X86::VCMPPHZ256rrik:
-  case X86::VCMPPHZrmik:     case X86::VCMPPHZrrik:
-  case X86::VCMPSHZrmi_Intk: case X86::VCMPSHZrri_Intk:
-  case X86::VCMPPHZ128rmbi:  case X86::VCMPPHZ128rmbik:
-  case X86::VCMPPHZ256rmbi:  case X86::VCMPPHZ256rmbik:
-  case X86::VCMPPHZrmbi:     case X86::VCMPPHZrmbik:
-  case X86::VCMPPHZrrib:     case X86::VCMPPHZrribk:
-  case X86::VCMPSHZrrib_Int: case X86::VCMPSHZrrib_Intk:
+  case X86::VCMPPDrmi:
+  case X86::VCMPPDrri:
+  case X86::VCMPPDYrmi:
+  case X86::VCMPPDYrri:
+  case X86::VCMPPDZ128rmi:
+  case X86::VCMPPDZ128rri:
+  case X86::VCMPPDZ256rmi:
+  case X86::VCMPPDZ256rri:
+  case X86::VCMPPDZrmi:
+  case X86::VCMPPDZrri:
+  case X86::VCMPPSrmi:
+  case X86::VCMPPSrri:
+  case X86::VCMPPSYrmi:
+  case X86::VCMPPSYrri:
+  case X86::VCMPPSZ128rmi:
+  case X86::VCMPPSZ128rri:
+  case X86::VCMPPSZ256rmi:
+  case X86::VCMPPSZ256rri:
+  case X86::VCMPPSZrmi:
+  case X86::VCMPPSZrri:
+  case X86::VCMPSDrmi:
+  case X86::VCMPSDrri:
+  case X86::VCMPSDZrmi:
+  case X86::VCMPSDZrri:
+  case X86::VCMPSDrmi_Int:
+  case X86::VCMPSDrri_Int:
+  case X86::VCMPSDZrmi_Int:
+  case X86::VCMPSDZrri_Int:
+  case X86::VCMPSSrmi:
+  case X86::VCMPSSrri:
+  case X86::VCMPSSZrmi:
+  case X86::VCMPSSZrri:
+  case X86::VCMPSSrmi_Int:
+  case X86::VCMPSSrri_Int:
+  case X86::VCMPSSZrmi_Int:
+  case X86::VCMPSSZrri_Int:
+  case X86::VCMPPDZ128rmik:
+  case X86::VCMPPDZ128rrik:
+  case X86::VCMPPDZ256rmik:
+  case X86::VCMPPDZ256rrik:
+  case X86::VCMPPDZrmik:
+  case X86::VCMPPDZrrik:
+  case X86::VCMPPSZ128rmik:
+  case X86::VCMPPSZ128rrik:
+  case X86::VCMPPSZ256rmik:
+  case X86::VCMPPSZ256rrik:
+  case X86::VCMPPSZrmik:
+  case X86::VCMPPSZrrik:
+  case X86::VCMPSDZrmi_Intk:
+  case X86::VCMPSDZrri_Intk:
+  case X86::VCMPSSZrmi_Intk:
+  case X86::VCMPSSZrri_Intk:
+  case X86::VCMPPDZ128rmbi:
+  case X86::VCMPPDZ128rmbik:
+  case X86::VCMPPDZ256rmbi:
+  case X86::VCMPPDZ256rmbik:
+  case X86::VCMPPDZrmbi:
+  case X86::VCMPPDZrmbik:
+  case X86::VCMPPSZ128rmbi:
+  case X86::VCMPPSZ128rmbik:
+  case X86::VCMPPSZ256rmbi:
+  case X86::VCMPPSZ256rmbik:
+  case X86::VCMPPSZrmbi:
+  case X86::VCMPPSZrmbik:
+  case X86::VCMPPDZrrib:
+  case X86::VCMPPDZrribk:
+  case X86::VCMPPSZrrib:
+  case X86::VCMPPSZrribk:
+  case X86::VCMPSDZrrib_Int:
+  case X86::VCMPSDZrrib_Intk:
+  case X86::VCMPSSZrrib_Int:
+  case X86::VCMPSSZrrib_Intk:
+  case X86::VCMPPHZ128rmi:
+  case X86::VCMPPHZ128rri:
+  case X86::VCMPPHZ256rmi:
+  case X86::VCMPPHZ256rri:
+  case X86::VCMPPHZrmi:
+  case X86::VCMPPHZrri:
+  case X86::VCMPSHZrmi:
+  case X86::VCMPSHZrri:
+  case X86::VCMPSHZrmi_Int:
+  case X86::VCMPSHZrri_Int:
+  case X86::VCMPPHZ128rmik:
+  case X86::VCMPPHZ128rrik:
+  case X86::VCMPPHZ256rmik:
+  case X86::VCMPPHZ256rrik:
+  case X86::VCMPPHZrmik:
+  case X86::VCMPPHZrrik:
+  case X86::VCMPSHZrmi_Intk:
+  case X86::VCMPSHZrri_Intk:
+  case X86::VCMPPHZ128rmbi:
+  case X86::VCMPPHZ128rmbik:
+  case X86::VCMPPHZ256rmbi:
+  case X86::VCMPPHZ256rmbik:
+  case X86::VCMPPHZrmbi:
+  case X86::VCMPPHZrmbik:
+  case X86::VCMPPHZrrib:
+  case X86::VCMPPHZrribk:
+  case X86::VCMPSHZrrib_Int:
+  case X86::VCMPSHZrrib_Intk:
     if (Imm >= 0 && Imm <= 31) {
       OS << '\t';
       printCMPMnemonic(MI, /*IsVCMP*/true, OS);
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
index 29a1866bf0..2284716d76 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp
@@ -272,24 +272,40 @@ void X86InstPrinterCommon::printCMPMnemonic(const MCInst *MI, bool IsVCmp,
   case X86::VCMPPSZrrib:    case X86::VCMPPSZrribk:
     OS << "ps\t";
     break;
-  case X86::CMPSDrmi:        case X86::CMPSDrri:
-  case X86::CMPSDrmi_Int:    case X86::CMPSDrri_Int:
-  case X86::VCMPSDrmi:       case X86::VCMPSDrri:
-  case X86::VCMPSDrmi_Int:   case X86::VCMPSDrri_Int:
-  case X86::VCMPSDZrmi:      case X86::VCMPSDZrri:
-  case X86::VCMPSDZrmi_Int:  case X86::VCMPSDZrri_Int:
-  case X86::VCMPSDZrmi_Intk: case X86::VCMPSDZrri_Intk:
-  case X86::VCMPSDZrrib_Int: case X86::VCMPSDZrrib_Intk:
+  case X86::CMPSDrmi:
+  case X86::CMPSDrri:
+  case X86::CMPSDrmi_Int:
+  case X86::CMPSDrri_Int:
+  case X86::VCMPSDrmi:
+  case X86::VCMPSDrri:
+  case X86::VCMPSDrmi_Int:
+  case X86::VCMPSDrri_Int:
+  case X86::VCMPSDZrmi:
+  case X86::VCMPSDZrri:
+  case X86::VCMPSDZrmi_Int:
+  case X86::VCMPSDZrri_Int:
+  case X86::VCMPSDZrmi_Intk:
+  case X86::VCMPSDZrri_Intk:
+  case X86::VCMPSDZrrib_Int:
+  case X86::VCMPSDZrrib_Intk:
     OS << "sd\t";
     break;
-  case X86::CMPSSrmi:        case X86::CMPSSrri:
-  case X86::CMPSSrmi_Int:    case X86::CMPSSrri_Int:
-  case X86::VCMPSSrmi:       case X86::VCMPSSrri:
-  case X86::VCMPSSrmi_Int:   case X86::VCMPSSrri_Int:
-  case X86::VCMPSSZrmi:      case X86::VCMPSSZrri:
-  case X86::VCMPSSZrmi_Int:  case X86::VCMPSSZrri_Int:
-  case X86::VCMPSSZrmi_Intk: case X86::VCMPSSZrri_Intk:
-  case X86::VCMPSSZrrib_Int: case X86::VCMPSSZrrib_Intk:
+  case X86::CMPSSrmi:
+  case X86::CMPSSrri:
+  case X86::CMPSSrmi_Int:
+  case X86::CMPSSrri_Int:
+  case X86::VCMPSSrmi:
+  case X86::VCMPSSrri:
+  case X86::VCMPSSrmi_Int:
+  case X86::VCMPSSrri_Int:
+  case X86::VCMPSSZrmi:
+  case X86::VCMPSSZrri:
+  case X86::VCMPSSZrmi_Int:
+  case X86::VCMPSSZrri_Int:
+  case X86::VCMPSSZrmi_Intk:
+  case X86::VCMPSSZrri_Intk:
+  case X86::VCMPSSZrrib_Int:
+  case X86::VCMPSSZrrib_Intk:
     OS << "ss\t";
     break;
   case X86::VCMPPHZ128rmi:  case X86::VCMPPHZ128rri:
@@ -304,10 +320,14 @@ void X86InstPrinterCommon::printCMPMnemonic(const MCInst *MI, bool IsVCmp,
   case X86::VCMPPHZrrib:    case X86::VCMPPHZrribk:
     OS << "ph\t";
     break;
-  case X86::VCMPSHZrmi:      case X86::VCMPSHZrri:
-  case X86::VCMPSHZrmi_Int:  case X86::VCMPSHZrri_Int:
-  case X86::VCMPSHZrrib_Int: case X86::VCMPSHZrrib_Intk:
-  case X86::VCMPSHZrmi_Intk: case X86::VCMPSHZrri_Intk:
+  case X86::VCMPSHZrmi:
+  case X86::VCMPSHZrri:
+  case X86::VCMPSHZrmi_Int:
+  case X86::VCMPSHZrri_Int:
+  case X86::VCMPSHZrrib_Int:
+  case X86::VCMPSHZrrib_Intk:
+  case X86::VCMPSHZrmi_Intk:
+  case X86::VCMPSHZrri_Intk:
     OS << "sh\t";
     break;
   }
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
index 7c8459a546..a7fea82e98 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86IntelInstPrinter.cpp
@@ -69,12 +69,18 @@ bool X86IntelInstPrinter::printVecCompareInstr(const MCInst *MI, raw_ostream &OS
   // Custom print the vector compare instructions to get the immediate
   // translated into the mnemonic.
   switch (MI->getOpcode()) {
-  case X86::CMPPDrmi:     case X86::CMPPDrri:
-  case X86::CMPPSrmi:     case X86::CMPPSrri:
-  case X86::CMPSDrmi:     case X86::CMPSDrri:
-  case X86::CMPSDrmi_Int: case X86::CMPSDrri_Int:
-  case X86::CMPSSrmi:     case X86::CMPSSrri:
-  case X86::CMPSSrmi_Int: case X86::CMPSSrri_Int:
+  case X86::CMPPDrmi:
+  case X86::CMPPDrri:
+  case X86::CMPPSrmi:
+  case X86::CMPPSrri:
+  case X86::CMPSDrmi:
+  case X86::CMPSDrri:
+  case X86::CMPSDrmi_Int:
+  case X86::CMPSDrri_Int:
+  case X86::CMPSSrmi:
+  case X86::CMPSSrri:
+  case X86::CMPSSrmi_Int:
+  case X86::CMPSSrri_Int:
     if (Imm >= 0 && Imm <= 7) {
       OS << '\t';
       printCMPMnemonic(MI, /*IsVCMP*/false, OS);
@@ -96,56 +102,106 @@ bool X86IntelInstPrinter::printVecCompareInstr(const MCInst *MI, raw_ostream &OS
     }
     break;
 
-  case X86::VCMPPDrmi:       case X86::VCMPPDrri:
-  case X86::VCMPPDYrmi:      case X86::VCMPPDYrri:
-  case X86::VCMPPDZ128rmi:   case X86::VCMPPDZ128rri:
-  case X86::VCMPPDZ256rmi:   case X86::VCMPPDZ256rri:
-  case X86::VCMPPDZrmi:      case X86::VCMPPDZrri:
-  case X86::VCMPPSrmi:       case X86::VCMPPSrri:
-  case X86::VCMPPSYrmi:      case X86::VCMPPSYrri:
-  case X86::VCMPPSZ128rmi:   case X86::VCMPPSZ128rri:
-  case X86::VCMPPSZ256rmi:   case X86::VCMPPSZ256rri:
-  case X86::VCMPPSZrmi:      case X86::VCMPPSZrri:
-  case X86::VCMPSDrmi:       case X86::VCMPSDrri:
-  case X86::VCMPSDZrmi:      case X86::VCMPSDZrri:
-  case X86::VCMPSDrmi_Int:   case X86::VCMPSDrri_Int:
-  case X86::VCMPSDZrmi_Int:  case X86::VCMPSDZrri_Int:
-  case X86::VCMPSSrmi:       case X86::VCMPSSrri:
-  case X86::VCMPSSZrmi:      case X86::VCMPSSZrri:
-  case X86::VCMPSSrmi_Int:   case X86::VCMPSSrri_Int:
-  case X86::VCMPSSZrmi_Int:  case X86::VCMPSSZrri_Int:
-  case X86::VCMPPDZ128rmik:  case X86::VCMPPDZ128rrik:
-  case X86::VCMPPDZ256rmik:  case X86::VCMPPDZ256rrik:
-  case X86::VCMPPDZrmik:     case X86::VCMPPDZrrik:
-  case X86::VCMPPSZ128rmik:  case X86::VCMPPSZ128rrik:
-  case X86::VCMPPSZ256rmik:  case X86::VCMPPSZ256rrik:
-  case X86::VCMPPSZrmik:     case X86::VCMPPSZrrik:
-  case X86::VCMPSDZrmi_Intk: case X86::VCMPSDZrri_Intk:
-  case X86::VCMPSSZrmi_Intk: case X86::VCMPSSZrri_Intk:
-  case X86::VCMPPDZ128rmbi:  case X86::VCMPPDZ128rmbik:
-  case X86::VCMPPDZ256rmbi:  case X86::VCMPPDZ256rmbik:
-  case X86::VCMPPDZrmbi:     case X86::VCMPPDZrmbik:
-  case X86::VCMPPSZ128rmbi:  case X86::VCMPPSZ128rmbik:
-  case X86::VCMPPSZ256rmbi:  case X86::VCMPPSZ256rmbik:
-  case X86::VCMPPSZrmbi:     case X86::VCMPPSZrmbik:
-  case X86::VCMPPDZrrib:     case X86::VCMPPDZrribk:
-  case X86::VCMPPSZrrib:     case X86::VCMPPSZrribk:
-  case X86::VCMPSDZrrib_Int: case X86::VCMPSDZrrib_Intk:
-  case X86::VCMPSSZrrib_Int: case X86::VCMPSSZrrib_Intk:
-  case X86::VCMPPHZ128rmi:   case X86::VCMPPHZ128rri:
-  case X86::VCMPPHZ256rmi:   case X86::VCMPPHZ256rri:
-  case X86::VCMPPHZrmi:      case X86::VCMPPHZrri:
-  case X86::VCMPSHZrmi:      case X86::VCMPSHZrri:
-  case X86::VCMPSHZrmi_Int:  case X86::VCMPSHZrri_Int:
-  case X86::VCMPPHZ128rmik:  case X86::VCMPPHZ128rrik:
-  case X86::VCMPPHZ256rmik:  case X86::VCMPPHZ256rrik:
-  case X86::VCMPPHZrmik:     case X86::VCMPPHZrrik:
-  case X86::VCMPSHZrmi_Intk: case X86::VCMPSHZrri_Intk:
-  case X86::VCMPPHZ128rmbi:  case X86::VCMPPHZ128rmbik:
-  case X86::VCMPPHZ256rmbi:  case X86::VCMPPHZ256rmbik:
-  case X86::VCMPPHZrmbi:     case X86::VCMPPHZrmbik:
-  case X86::VCMPPHZrrib:     case X86::VCMPPHZrribk:
-  case X86::VCMPSHZrrib_Int: case X86::VCMPSHZrrib_Intk:
+  case X86::VCMPPDrmi:
+  case X86::VCMPPDrri:
+  case X86::VCMPPDYrmi:
+  case X86::VCMPPDYrri:
+  case X86::VCMPPDZ128rmi:
+  case X86::VCMPPDZ128rri:
+  case X86::VCMPPDZ256rmi:
+  case X86::VCMPPDZ256rri:
+  case X86::VCMPPDZrmi:
+  case X86::VCMPPDZrri:
+  case X86::VCMPPSrmi:
+  case X86::VCMPPSrri:
+  case X86::VCMPPSYrmi:
+  case X86::VCMPPSYrri:
+  case X86::VCMPPSZ128rmi:
+  case X86::VCMPPSZ128rri:
+  case X86::VCMPPSZ256rmi:
+  case X86::VCMPPSZ256rri:
+  case X86::VCMPPSZrmi:
+  case X86::VCMPPSZrri:
+  case X86::VCMPSDrmi:
+  case X86::VCMPSDrri:
+  case X86::VCMPSDZrmi:
+  case X86::VCMPSDZrri:
+  case X86::VCMPSDrmi_Int:
+  case X86::VCMPSDrri_Int:
+  case X86::VCMPSDZrmi_Int:
+  case X86::VCMPSDZrri_Int:
+  case X86::VCMPSSrmi:
+  case X86::VCMPSSrri:
+  case X86::VCMPSSZrmi:
+  case X86::VCMPSSZrri:
+  case X86::VCMPSSrmi_Int:
+  case X86::VCMPSSrri_Int:
+  case X86::VCMPSSZrmi_Int:
+  case X86::VCMPSSZrri_Int:
+  case X86::VCMPPDZ128rmik:
+  case X86::VCMPPDZ128rrik:
+  case X86::VCMPPDZ256rmik:
+  case X86::VCMPPDZ256rrik:
+  case X86::VCMPPDZrmik:
+  case X86::VCMPPDZrrik:
+  case X86::VCMPPSZ128rmik:
+  case X86::VCMPPSZ128rrik:
+  case X86::VCMPPSZ256rmik:
+  case X86::VCMPPSZ256rrik:
+  case X86::VCMPPSZrmik:
+  case X86::VCMPPSZrrik:
+  case X86::VCMPSDZrmi_Intk:
+  case X86::VCMPSDZrri_Intk:
+  case X86::VCMPSSZrmi_Intk:
+  case X86::VCMPSSZrri_Intk:
+  case X86::VCMPPDZ128rmbi:
+  case X86::VCMPPDZ128rmbik:
+  case X86::VCMPPDZ256rmbi:
+  case X86::VCMPPDZ256rmbik:
+  case X86::VCMPPDZrmbi:
+  case X86::VCMPPDZrmbik:
+  case X86::VCMPPSZ128rmbi:
+  case X86::VCMPPSZ128rmbik:
+  case X86::VCMPPSZ256rmbi:
+  case X86::VCMPPSZ256rmbik:
+  case X86::VCMPPSZrmbi:
+  case X86::VCMPPSZrmbik:
+  case X86::VCMPPDZrrib:
+  case X86::VCMPPDZrribk:
+  case X86::VCMPPSZrrib:
+  case X86::VCMPPSZrribk:
+  case X86::VCMPSDZrrib_Int:
+  case X86::VCMPSDZrrib_Intk:
+  case X86::VCMPSSZrrib_Int:
+  case X86::VCMPSSZrrib_Intk:
+  case X86::VCMPPHZ128rmi:
+  case X86::VCMPPHZ128rri:
+  case X86::VCMPPHZ256rmi:
+  case X86::VCMPPHZ256rri:
+  case X86::VCMPPHZrmi:
+  case X86::VCMPPHZrri:
+  case X86::VCMPSHZrmi:
+  case X86::VCMPSHZrri:
+  case X86::VCMPSHZrmi_Int:
+  case X86::VCMPSHZrri_Int:
+  case X86::VCMPPHZ128rmik:
+  case X86::VCMPPHZ128rrik:
+  case X86::VCMPPHZ256rmik:
+  case X86::VCMPPHZ256rrik:
+  case X86::VCMPPHZrmik:
+  case X86::VCMPPHZrrik:
+  case X86::VCMPSHZrmi_Intk:
+  case X86::VCMPSHZrri_Intk:
+  case X86::VCMPPHZ128rmbi:
+  case X86::VCMPPHZ128rmbik:
+  case X86::VCMPPHZ256rmbi:
+  case X86::VCMPPHZ256rmbik:
+  case X86::VCMPPHZrmbi:
+  case X86::VCMPPHZrmbik:
+  case X86::VCMPPHZrrib:
+  case X86::VCMPPHZrribk:
+  case X86::VCMPSHZrrib_Int:
+  case X86::VCMPSHZrrib_Intk:
     if (Imm >= 0 && Imm <= 31) {
       OS << '\t';
       printCMPMnemonic(MI, /*IsVCMP*/true, OS);
diff --git a/llvm/lib/Target/X86/X86FastISel.cpp b/llvm/lib/Target/X86/X86FastISel.cpp
index 9f0b5f32df..4d30e38f73 100644
--- a/llvm/lib/Target/X86/X86FastISel.cpp
+++ b/llvm/lib/Target/X86/X86FastISel.cpp
@@ -2198,7 +2198,7 @@ bool X86FastISel::X86FastEmitSSESelect(MVT RetVT, const Instruction *I) {
     const TargetRegisterClass *VK1 = &X86::VK1RegClass;
 
     unsigned CmpOpcode =
-      (RetVT == MVT::f32) ? X86::VCMPSSZrri : X86::VCMPSDZrri;
+        (RetVT == MVT::f32) ? X86::VCMPSSZrri : X86::VCMPSDZrri;
     Register CmpReg = fastEmitInst_rri(CmpOpcode, VK1, CmpLHSReg, CmpRHSReg,
                                        CC);
 
@@ -2227,8 +2227,7 @@ bool X86FastISel::X86FastEmitSSESelect(MVT RetVT, const Instruction *I) {
     // uses XMM0 as the selection register. That may need just as many
     // instructions as the AND/ANDN/OR sequence due to register moves, so
     // don't bother.
-    unsigned CmpOpcode =
-      (RetVT == MVT::f32) ? X86::VCMPSSrri : X86::VCMPSDrri;
+    unsigned CmpOpcode = (RetVT == MVT::f32) ? X86::VCMPSSrri : X86::VCMPSDrri;
     unsigned BlendOpcode =
       (RetVT == MVT::f32) ? X86::VBLENDVPSrr : X86::VBLENDVPDrr;
 
@@ -2242,9 +2241,8 @@ bool X86FastISel::X86FastEmitSSESelect(MVT RetVT, const Instruction *I) {
   } else {
     // Choose the SSE instruction sequence based on data type (float or double).
     static const uint16_t OpcTable[2][4] = {
-      { X86::CMPSSrri,  X86::ANDPSrr,  X86::ANDNPSrr,  X86::ORPSrr  },
-      { X86::CMPSDrri,  X86::ANDPDrr,  X86::ANDNPDrr,  X86::ORPDrr  }
-    };
+        {X86::CMPSSrri, X86::ANDPSrr, X86::ANDNPSrr, X86::ORPSrr},
+        {X86::CMPSDrri, X86::ANDPDrr, X86::ANDNPDrr, X86::ORPDrr}};
 
     const uint16_t *Opc = nullptr;
     switch (RetVT.SimpleTy) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/84496


More information about the llvm-commits mailing list