[llvm] [RISCV][NFC] Simplify RISCVInstrInfo::copyPhysReg (PR #84139)
Luke Lau via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 6 01:30:33 PST 2024
================
@@ -473,122 +473,48 @@ void RISCVInstrInfo::copyPhysReg(MachineBasicBlock &MBB,
return;
}
- if (RISCV::FPR32RegClass.contains(DstReg) &&
- RISCV::GPRRegClass.contains(SrcReg)) {
- BuildMI(MBB, MBBI, DL, get(RISCV::FMV_W_X), DstReg)
- .addReg(SrcReg, getKillRegState(KillSrc));
- return;
- }
-
- if (RISCV::GPRRegClass.contains(DstReg) &&
- RISCV::FPR32RegClass.contains(SrcReg)) {
- BuildMI(MBB, MBBI, DL, get(RISCV::FMV_X_W), DstReg)
- .addReg(SrcReg, getKillRegState(KillSrc));
- return;
- }
-
- if (RISCV::FPR64RegClass.contains(DstReg) &&
- RISCV::GPRRegClass.contains(SrcReg)) {
- assert(STI.getXLen() == 64 && "Unexpected GPR size");
- BuildMI(MBB, MBBI, DL, get(RISCV::FMV_D_X), DstReg)
- .addReg(SrcReg, getKillRegState(KillSrc));
- return;
- }
-
- if (RISCV::GPRRegClass.contains(DstReg) &&
- RISCV::FPR64RegClass.contains(SrcReg)) {
- assert(STI.getXLen() == 64 && "Unexpected GPR size");
----------------
lukel97 wrote:
This loses the asserts?
I don't think the scalar registers have that much duplication. What would you think about just deduplicating the vector registers instead?
https://github.com/llvm/llvm-project/pull/84139
More information about the llvm-commits
mailing list