[llvm] [DirectX] Add DXIL_MODULE_FLAG for ShaderFlags. (PR #83217)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 07:59:52 PST 2024


================
@@ -51,7 +51,10 @@ void ComputedShaderFlags::print(raw_ostream &OS) const {
   if (FlagVal == 0)
     return;
   OS << "; Note: shader requires additional functionality:\n";
-#define SHADER_FEATURE_FLAG(bit, FlagName, Str)                                \
+#define SHADER_FEATURE_FLAG(bit, DxilModuleNum, FlagName, Str)                 \
----------------
llvm-beanz wrote:

Your suggestion is good, but also please fix the capitalization on the first argument:

```suggestion
#define SHADER_FEATURE_FLAG(Bit, DxilModuleBit, FlagName, Str)                 \
```

https://github.com/llvm/llvm-project/pull/83217


More information about the llvm-commits mailing list