[llvm] [X86] Transform `(xor x, SIGN_BIT)` -> `(add x, SIGN_BIT)` 32 bit and smaller scalars (PR #83659)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 2 10:39:59 PST 2024
goldsteinn wrote:
> We already do some of this in X86DAGToDAGISel::matchAddressRecursively - maybe see why these cases weren't working there?
I see:
```
case ISD::OR:
case ISD::XOR:
// See if we can treat the OR/XOR node as an ADD node.
if (!CurDAG->isADDLike(N))
break;
[[fallthrough]];
case ISD::ADD:
if (!matchAdd(N, AM, Depth))
return false;
break;
```
Which isn't quite the same, or is there another transform im missing?
But it looks to me like whatever we are doing in `DAGToDag` isn't handling non-i32 types.
https://github.com/llvm/llvm-project/pull/83659
More information about the llvm-commits
mailing list