[llvm] 1d03d59 - Revert "add initialized attribute LangRef"

[David Blaikie via llvm-commits]

thanks!

On Wed, Feb 21, 2024 at 2:09 PM Haopeng Liu <haopliu at google.com> wrote:

> Thanks for the reminder, David! Will add more comments about the revert
> reason in the future :-D
>
> On Tue, Feb 20, 2024 at 12:13 PM David Blaikie <dblaikie at gmail.com> wrote:
>
>> Good to mention in the commit message why a patch is being reverted.
>>
>> On Thu, Feb 15, 2024 at 2:27 PM Haopeng Liu via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>>
>>> Author: Haopeng Liu
>>> Date: 2024-02-15T22:23:54Z
>>> New Revision: 1d03d59aff07d40420a08af13ee74fed9846d7d8
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8.diff
>>>
>>> LOG: Revert "add initialized attribute LangRef"
>>>
>>> This reverts commit 69a96ae0e80f0e62c1f25a1c255a3f46ff7dc9e8.
>>>
>>> Added:
>>>
>>>
>>> Modified:
>>>     llvm/docs/LangRef.rst
>>>
>>> Removed:
>>>
>>>
>>>
>>>
>>> ################################################################################
>>> diff  --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
>>> index 6f7a0fd3f7ba5a..fd2e3aacd0169c 100644
>>> --- a/llvm/docs/LangRef.rst
>>> +++ b/llvm/docs/LangRef.rst
>>> @@ -1589,23 +1589,6 @@ Currently, only the following parameter
>>> attributes are defined:
>>>      ``readonly`` or a ``memory`` attribute that does not contain
>>>      ``argmem: write``.
>>>
>>> -``initialized((Lo1,Hi1),...)``
>>> -    This attribute is a list of const ranges in ascending order with no
>>> -    overlapping or continuous. It indicates that the function
>>> initializes the
>>> -    memory through the pointer argument, [%p+LoN, %p+HiN), and there is
>>> no read
>>> -    before initialization in the function. (even though it may read
>>> before
>>> -    initializating the memory that the pointer points to).
>>> -
>>> -    The ``writable`` or ``dereferenceable`` attribute does not imply
>>> -    ``initialized`` attribute, however the ``initialized`` argument
>>> does imply
>>> -    ``writable`` and ``dereferenceable`` in the specified spaces.
>>> -
>>> -    The ``initialized`` attribute can combine with ``writeonly``
>>> attribute, but
>>> -    cannot be combined with ``readnone``, ``readonly`` or a memory
>>> attribute
>>> -    that does not contain ``argmem: write``.
>>> -
>>> -    [TODO: unwind]
>>> -
>>>  ``dead_on_unwind``
>>>      At a high level, this attribute indicates that the pointer argument
>>> is dead
>>>      if the call unwinds, in the sense that the caller will not depend
>>> on the
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20240226/84aa5df4/attachment.html>