<div dir="ltr">thanks!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 21, 2024 at 2:09 PM Haopeng Liu <<a href="mailto:haopliu@google.com">haopliu@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Thanks for the reminder, David! Will add more comments about the revert reason in the future :-D<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 20, 2024 at 12:13 PM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Good to mention in the commit message why a patch is being reverted. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 15, 2024 at 2:27 PM Haopeng Liu via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Haopeng Liu<br>
Date: 2024-02-15T22:23:54Z<br>
New Revision: 1d03d59aff07d40420a08af13ee74fed9846d7d8<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1d03d59aff07d40420a08af13ee74fed9846d7d8.diff</a><br>
<br>
LOG: Revert "add initialized attribute LangRef"<br>
<br>
This reverts commit 69a96ae0e80f0e62c1f25a1c255a3f46ff7dc9e8.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/docs/LangRef.rst<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst<br>
index 6f7a0fd3f7ba5a..fd2e3aacd0169c 100644<br>
--- a/llvm/docs/LangRef.rst<br>
+++ b/llvm/docs/LangRef.rst<br>
@@ -1589,23 +1589,6 @@ Currently, only the following parameter attributes are defined:<br>
``readonly`` or a ``memory`` attribute that does not contain<br>
``argmem: write``.<br>
<br>
-``initialized((Lo1,Hi1),...)``<br>
- This attribute is a list of const ranges in ascending order with no<br>
- overlapping or continuous. It indicates that the function initializes the<br>
- memory through the pointer argument, [%p+LoN, %p+HiN), and there is no read<br>
- before initialization in the function. (even though it may read before<br>
- initializating the memory that the pointer points to).<br>
-<br>
- The ``writable`` or ``dereferenceable`` attribute does not imply<br>
- ``initialized`` attribute, however the ``initialized`` argument does imply<br>
- ``writable`` and ``dereferenceable`` in the specified spaces.<br>
-<br>
- The ``initialized`` attribute can combine with ``writeonly`` attribute, but<br>
- cannot be combined with ``readnone``, ``readonly`` or a memory attribute<br>
- that does not contain ``argmem: write``.<br>
-<br>
- [TODO: unwind]<br>
-<br>
``dead_on_unwind``<br>
At a high level, this attribute indicates that the pointer argument is dead<br>
if the call unwinds, in the sense that the caller will not depend on the<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>