[llvm] [CodeGen] Simplify updateLiveIn in MachineSink (PR #79831)

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 01:53:38 PST 2024


qcolombet wrote:

Sounds good let’s go with this patch and see if anybody complains about the removal of the lanes in the live ins. I expect that people that care about that would use the LiveIIntervals anyway.


> You mean the whole tablegen `Register` field `list<Register> Aliases = [];` mechanism is an abuse of the system? Maybe, but it seems like quite a lot of work to get rid of the existing in-tree uses.

I mean the part where they don’t actually share a regunit.
And to be clear I’m not advocating for removing the aliases field.

> 
> By the way I have yet another idea for fixing the reported […]

Sounds like a plan, although I’m a little worried about the impact on things like pressure sets.
I’d say give it a try and we’ll see how it goes!



https://github.com/llvm/llvm-project/pull/79831


More information about the llvm-commits mailing list