[llvm] [DirectX][NFC] Use LLVM Types in DXIL Operation specifications in DXIL.td (PR #81692)
Justin Bogner via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 14 12:10:43 PST 2024
================
@@ -151,7 +139,8 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
DXILParameter::DXILParameter(const Record *R) {
Name = R->getValueAsString("Name");
Pos = R->getValueAsInt("Pos");
- Kind = parameterTypeNameToKind(R->getValueAsString("Type"));
+ Kind = getDXILTypeNameToKind(
+ R->getValue("ParamType")->getValue()->getAsString());
----------------
bogner wrote:
The name `getDXILTypeNameToKind` is a bit confusing, both because it doesn't "get" a "DXILTypeName" and because "get" usually implies an accessor or something that's otherwise pretty free. Maybe something like "lookupParameterKind" would be better.
https://github.com/llvm/llvm-project/pull/81692
More information about the llvm-commits
mailing list