[llvm] 1395e58 - [X86][CodeGen] Set mayLoad = 1 for LZCNT/POPCNT/TZCNTrm_(EVEX|NF)

[Shengchen Kan via llvm-commits]

Author: Shengchen Kan
Date: 2024-02-01T14:13:29+08:00
New Revision: 1395e582f334f3db354b6e999d86a8662819e890

URL: https://github.com/llvm/llvm-project/commit/1395e582f334f3db354b6e999d86a8662819e890
DIFF: https://github.com/llvm/llvm-project/commit/1395e582f334f3db354b6e999d86a8662819e890.diff

LOG: [X86][CodeGen] Set mayLoad = 1 for LZCNT/POPCNT/TZCNTrm_(EVEX|NF)

Promoted and NF LZCNT/POPCNT/TZCNT were supported in #79954.
B/c null_frag is used in the patterns for these variants, tablgen can
not infer mayLoad = 1 for them.

This can be tested by MCA tests, which will be added after
-mcpu=<cpu_with_apx> is supported.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86InstrMisc.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86InstrMisc.td b/llvm/lib/Target/X86/X86InstrMisc.td
index a39b805927137..496a7e6b29436 100644
--- a/llvm/lib/Target/X86/X86InstrMisc.td
+++ b/llvm/lib/Target/X86/X86InstrMisc.td
@@ -1166,11 +1166,12 @@ multiclass Lzcnt<bits<8> o, string m, SDPatternOperator node, X86TypeInfo t,
                       [(set t.RegClass:$dst, (node t.RegClass:$src1)),
                                               (implicit EFLAGS)]>,
                   TB, Sched<[schedrr]>;
-  def rm#suffix : ITy<o, MRMSrcMem, t, (outs t.RegClass:$dst),
-                      (ins t.MemOperand:$src1), m, unaryop_ndd_args,
-                      [(set t.RegClass:$dst, (node (t.LoadNode addr:$src1))),
-                                              (implicit EFLAGS)]>,
-                  TB, Sched<[schedrm]>;
+  let mayLoad = 1 in
+    def rm#suffix : ITy<o, MRMSrcMem, t, (outs t.RegClass:$dst),
+                        (ins t.MemOperand:$src1), m, unaryop_ndd_args,
+                        [(set t.RegClass:$dst, (node (t.LoadNode addr:$src1))),
+                                                (implicit EFLAGS)]>,
+                    TB, Sched<[schedrm]>;
 }
 
 let Predicates = [HasLZCNT], Defs = [EFLAGS] in {