[llvm] [docs] Make rebase advice more explicit for cases where pre-commit CI is failing (PR #76704)
    Mehdi Amini via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jan  2 05:40:22 PST 2024
    
    
  
================
@@ -105,7 +105,9 @@ branch that's the root of the Pull Request during the review. This action will
 make the context of the old changes and comments harder to find and read.
 
 Sometimes, a rebase might be needed to update your branch with a fix for a test
-or in some dependent code.
+or in some dependent code. This is especially encouraged if it turns out that
+the upstream base commit used for your branch had test failures, meaning the
+pre-commit CI results are not useful.
----------------
joker-eph wrote:
What about:
> This is especially encouraged if it turns out that the upstream base commit used for your branch had test failures, meaning the pre-commit CI results can't be shown as cleanly passing.
https://github.com/llvm/llvm-project/pull/76704
    
    
More information about the llvm-commits
mailing list