[llvm] [Orc][examples] Fix lljit-with-remote-debugging test failure (PR #74764)

via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 08:33:25 PST 2023


lhames wrote:

> > I missed this earlier -- that's a good idea. `LLJIT` seems like the right place to handle this: `addIRModule` can check for an empty triple and replace it with the triple reported through the `ExecutionSession`.
> 
> That's been done by Stefan in [d86a937](https://github.com/llvm/llvm-project/commit/d86a93782f4ea476b7fa6751f849fb4ada3df852).

Stefan's change was to the testcase. I was proposing to change `LLJIT` itself, though now that I've taken a look I can see that it wouldn't have made a difference here: The testcase triple was being used to construct the target (via `JITTargetMachineBuilder`) and that's why the empty triple was causing a "no target" error. Normally the target is constructed using the `ExecutionSession`'s target triple, and LLVM optimizations and CodeGen will happily process a module with an empty triple.

https://github.com/llvm/llvm-project/pull/74764


More information about the llvm-commits mailing list