[llvm] [AMDGPU][NFC] Test autogenerated llc tests for COV5 (PR #74339)
Saiyedul Islam via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 8 12:19:30 PST 2023
saiislam wrote:
> > The change itself seems fine (though the new metadata spam is a bit annoying, and should eventually be removed).
> > The DAG vs. GlobalISel divergence in some of these cases is concerning and shouldn't be happening
>
> The queue_ptr offset was incorrectly dropped for SDAG. Can you include the following fix? Thanks.
>
> diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp index a7f4d63229b7..be301246f23a 100644 --- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp +++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp @@ -1791,7 +1791,7 @@ SDValue SITargetLowering::lowerKernArgParameterPtr(SelectionDAG &DAG, // We may not have the kernarg segment argument if we have no kernel // arguments. if (!InputPtrReg)
>
> * return DAG.getConstant(0, SL, PtrVT); // Should be Offset to access the implicit kernel argument
>
> * return DAG.getConstant(Offset, SL, PtrVT);
Thank you @changpeng . I have incorporated your change and regenerated all the tests.
Please review again.
https://github.com/llvm/llvm-project/pull/74339
More information about the llvm-commits
mailing list