[llvm] Create a CharSetConverter class with both iconv and icu support (PR #74516)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 12:17:26 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 1e3af94253cebb054db5d2050e00af0169862b39 509d698ec793f9dc9e096044404ac4c0f280ec3f -- llvm/include/llvm/Support/CharSet.h llvm/lib/Support/CharSet.cpp llvm/unittests/Support/CharSetTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/unittests/Support/CharSetTest.cpp b/llvm/unittests/Support/CharSetTest.cpp
index 572c4bfc7f..2f2d8f9710 100644
--- a/llvm/unittests/Support/CharSetTest.cpp
+++ b/llvm/unittests/Support/CharSetTest.cpp
@@ -6,8 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "llvm/ADT/SmallString.h"
 #include "llvm/Support/CharSet.h"
+#include "llvm/ADT/SmallString.h"
 #include "gtest/gtest.h"
 using namespace llvm;
 
@@ -221,7 +221,8 @@ TEST(CharSet, ShiftState2022Flush) {
     return;
   }
 
-  // This should emit an error; there is a malformed multibyte character in the input string.
+  // This should emit an error; there is a malformed multibyte character in the
+  // input string.
   std::error_code EC0 = ConvTo2022Flush->convert(Src0, Dst0, true);
   EXPECT_TRUE(EC0);
   std::error_code EC1 = ConvTo2022Flush->flush();
@@ -244,7 +245,8 @@ TEST(CharSet, ShiftStateIBM939Flush) {
     return;
   }
 
-  // This should emit an error; there is a malformed multibyte character in the input string.
+  // This should emit an error; there is a malformed multibyte character in the
+  // input string.
   std::error_code EC0 = ConvTo939Flush->convert(Src0, Dst0, true);
   EXPECT_TRUE(EC0);
   std::error_code EC1 = ConvTo939Flush->flush();

``````````

</details>


https://github.com/llvm/llvm-project/pull/74516


More information about the llvm-commits mailing list