[llvm] Disable fail-fast for libc++ builders. (PR #74485)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 07:23:05 PST 2023


https://github.com/EricWF updated https://github.com/llvm/llvm-project/pull/74485

>From 77cc25eb6e67528f1c3148f6a787cdb20982983c Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Tue, 5 Dec 2023 10:20:06 -0500
Subject: [PATCH] Disable fail-fast for libc++ builders.

It seems the fail fast just doesn't strike the right balance.
It wastes too many resources, especially if a build is killed because
the machine it was running on got preempted.

Instead, we should simply not run any future jobs if a failure has
occured, while letting the already running jobs finish.
---
 .github/workflows/libcxx-build-and-test.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 83786052a5391..268e1033387dc 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -53,7 +53,7 @@ jobs:
     runs-on: libcxx-runners-8-set
     continue-on-error: false
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         config: [
           'generic-cxx03',
@@ -92,7 +92,7 @@ jobs:
     needs: [ stage1 ]
     continue-on-error: false
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         config: [
           'generic-cxx11',



More information about the llvm-commits mailing list