[llvm] Disable fail-fast for libc++ builders. (PR #74485)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 07:22:13 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-github-workflow

Author: Eric (EricWF)

<details>
<summary>Changes</summary>

It seems the fail fast just doesn't strike the right balance.
It wastes too many resources, especially if a build is killed because
the machine it was running on got preempted.

Instead, we should simply not run any future jobs if a failure has
occured, while letting the already running jobs finish.


---
Full diff: https://github.com/llvm/llvm-project/pull/74485.diff


1 Files Affected:

- (modified) .github/workflows/libcxx-build-and-test.yaml (+1-1) 


``````````diff
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 83786052a5391..68dafe0f34f45 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -92,7 +92,7 @@ jobs:
     needs: [ stage1 ]
     continue-on-error: false
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         config: [
           'generic-cxx11',

``````````

</details>


https://github.com/llvm/llvm-project/pull/74485


More information about the llvm-commits mailing list