[llvm] [VFABI] Improve VFABI unit tests (PR #73907)
Maciej Gabka via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 30 01:47:31 PST 2023
================
@@ -44,10 +46,11 @@ class VFABIParserTest : public ::testing::Test {
FunctionCallee F;
protected:
- // Referencies to the parser output field.
+ // References to the parser output field.
ElementCount &VF = Info.Shape.VF;
VFISAKind &ISA = Info.ISA;
SmallVector<VFParameter, 8> &Parameters = Info.Shape.Parameters;
----------------
mgabka wrote:
wouldn't be more clear to call VecFuncParamaters? to avoid confusion in the checks like:
EXPECT_EQ(Parameters.size(), (unsigned)5);
EXPECT_TRUE(matchScalarParametersNum());
where it is not clear why we check it twice.
WDYT?
https://github.com/llvm/llvm-project/pull/73907
More information about the llvm-commits
mailing list