[llvm] [VFABI] Improve VFABI unit tests (PR #73907)

Maciej Gabka via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 01:47:31 PST 2023


================
@@ -140,8 +147,10 @@ TEST_F(VFABIParserTest, OnlyValidNames) {
 }
 
 TEST_F(VFABIParserTest, ParamListParsing) {
-  EXPECT_TRUE(invokeParser("_ZGVnN2vl16Ls32R3l_foo"));
+  EXPECT_TRUE(invokeParser("_ZGVnN2vl16Ls32R3l_foo", "",
----------------
mgabka wrote:

so I think that this test should fail, as the mangled name is for a scalar function called foo, so I think we should faill if the scalar function name does not match.

https://github.com/llvm/llvm-project/pull/73907


More information about the llvm-commits mailing list