[llvm] [runtimes] Add missing test dependencies to check-all (PR #72955)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 14:22:28 PST 2023


tstellar wrote:

It looks like this change uncovered an existing problem where the code in llvm/runtimes/CMakeLists.txt assumes that if LLVM_INCLUDE_TESTS=ON is set that tests will be enabled for the runtime builds too.  However, this configuration breaks this assumption by passing -DRUNTIMES_aarch64-linux-android21_LLVM_INCLUDE_TESTS=OFF, which disables the tests for the runtime build. Even without this change, trying to use targets like 'ninja test-depends` or `ninja check-compiler-rt-aarch64-linux-android21` will fail.

I think I can come up with a fix to make this patch work, but it seems like there may be some other problems here that haven't been uncovered yet.



https://github.com/llvm/llvm-project/pull/72955


More information about the llvm-commits mailing list