[llvm] [IR] Add disjoint flag for Or instructions. (PR #72583)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 10:58:55 PST 2023


nikic wrote:

> This mostly LGTM, but I see two questions that haven't been addressed:
> 
>     * Should a test be added to Bitcode/compatibility (this seems not to have been done consistently in recent times, but the answer is probably still yes)

I'd probably say no on this one, because the "release process" for that file has not been followed since LLVM 6, for more than ten releases. We should probably just remove the relevant section of the docs.

> * Should the setter/getter be moved to PossiblyDisjointInst (the other discussion does suggest that this should probably be done)

I'm neutral on this one. The current implementation matches existing practice, but I wouldn't mind giving the more principled design a try either.

https://github.com/llvm/llvm-project/pull/72583


More information about the llvm-commits mailing list