[llvm] [IR] Add disjoint flag for Or instructions. (PR #72583)
Nicolai Hähnle via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 22 10:26:34 PST 2023
https://github.com/nhaehnle commented:
This mostly LGTM, but I see two questions that haven't been addressed:
* Should a test be added to Bitcode/compatibility (this seems not to have been done consistently in recent times, but the answer is probably still yes)
* Should the setter/getter be moved to PossiblyDisjointInst (the other discussion does suggest that this should probably be done)
https://github.com/llvm/llvm-project/pull/72583
More information about the llvm-commits
mailing list