[compiler-rt] [ASan][Windows] Synchronizing ASAN init on Windows (PR #71833)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 09:49:59 PST 2023


================
@@ -93,6 +97,11 @@ AsanThreadContext *GetThreadContextByTidLocked(u32 tid) {
 AsanThread *AsanThread::Create(const void *start_data, uptr data_size,
                                u32 parent_tid, StackTrace *stack,
                                bool detached) {
+#if SANITIZER_WINDOWS
----------------
vitalybuka wrote:

You replied as "will do" to some items, as #if
But I see update in this PR.

Also there are https://github.com/zahiraam/llvm-project/commit/8e9ce62cf037767963ecd1a48aeb491bc0ef5863
you want to create PR for them?

BTW. There is https://github.com/getcord/spr which is proposed to be used for stacked code review, similar to we have in Phabricator, you may try that.

https://github.com/llvm/llvm-project/pull/71833


More information about the llvm-commits mailing list