[llvm] [runtimes] Add missing test dependencies to check-all (PR #72955)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 21:56:13 PST 2023


https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/72955

The test-depends target contained all the dependencies needed to run the runtimes tests, but it was never added as a dependency of check-all. This caused some of the tsan tests to fail, since the custom libcxx build the tests were looking for was never built.  Besides the tsan failures, this fixes all the other test failures I was seeing with:
cmake -G Ninja -B release-build -S llvm \
        -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
        -DCMAKE_BUILD_TYPE=Release \
        -DLLVM_ENABLE_ASSERTIONS=OFF \
        -DLLVM_ENABLE_PROJECTS="clang;lld" \
        -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt"

This is the same configuration the test-release.sh script uses, so I'm hoping this will also fix all the test failures we've been seeing when building the releases.

Fixes #58680

>From fe09b75274733c2bfb14400893bbe2e8fd9f5efc Mon Sep 17 00:00:00 2001
From: Tom Stellard <tstellar at redhat.com>
Date: Tue, 21 Nov 2023 05:34:08 +0000
Subject: [PATCH] [runtimes] Add missing test dependencies to check-all

The test-depends target contained all the dependencies needed to run the
runtimes tests, but it was never added as a dependency of check-all.
This led to some of the tsan tests to fail, since the custom libcxx
build they were using was never built.

Fixes #58680
---
 llvm/CMakeLists.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 7ff3acd48304de7..d468a92bf427ae0 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -1249,6 +1249,7 @@ if( LLVM_INCLUDE_TESTS )
   add_custom_target(test-depends
       DEPENDS ${LLVM_ALL_LIT_DEPENDS} ${LLVM_ALL_ADDITIONAL_TEST_DEPENDS})
   set_target_properties(test-depends PROPERTIES FOLDER "Tests")
+  add_dependencies(check-all test-depends)
 endif()
 
 if (LLVM_INCLUDE_DOCS)



More information about the llvm-commits mailing list