[compiler-rt] [sanitizer_symbolizer] Add initial symbolizer markup (PR #72605)

Andres Villegas via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 14:48:35 PST 2023


=?utf-8?q?Andrés?= Villegas <andresvi at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/72605 at github.com>


================
@@ -59,8 +45,27 @@ const char *FormattedStackTracePrinter::StripFunctionName(
   return function;
 }
 
-// sanitizer_symbolizer_markup.cpp implements these differently.
-#if !SANITIZER_SYMBOLIZER_MARKUP
+// sanitizer_symbolizer_markup_fuchsia.cpp implements these differently.
+#if !SANITIZER_SYMBOLIZER_MARKUP_FUCHSIA
+
+StackTracePrinter *StackTracePrinter::GetOrInit() {
----------------
avillega wrote:

It means it won't be used if we are compiling for fuchsia, this one was part of the motivation on renaming this definition. `StackTracePrinter::GetOrInit` is implemented a bit different when compiling for fuchsia `compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup_fuchsia.cpp:26`

https://github.com/llvm/llvm-project/pull/72605


More information about the llvm-commits mailing list