[compiler-rt] [sanitizer_symbolizer] Add initial symbolizer markup (PR #72605)
Andres Villegas via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 17 14:48:35 PST 2023
=?utf-8?q?Andrés?= Villegas <andresvi at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/72605 at github.com>
================
@@ -322,11 +327,12 @@ void FormattedStackTracePrinter::RenderData(InternalScopedString *buffer,
}
}
-#endif // !SANITIZER_SYMBOLIZER_MARKUP
+#endif // !SANITIZER_SYMBOLIZER_MARKUP_FUCHSIA
-void FormattedStackTracePrinter::RenderSourceLocation(
- InternalScopedString *buffer, const char *file, int line, int column,
- bool vs_style, const char *strip_path_prefix) {
+void StackTracePrinter::RenderSourceLocation(InternalScopedString *buffer,
+ const char *file, int line,
+ int column, bool vs_style,
+ const char *strip_path_prefix) {
----------------
avillega wrote:
The change is that this and `RenderModuleLocation` have the same implementation for the `FormattedStackTracePrinter` and the `MarkupStackTracePrinter` before introducing the Markup specific code, this change made no much sense.
https://github.com/llvm/llvm-project/pull/72605
More information about the llvm-commits
mailing list