[compiler-rt] [asan][win][msvc] override new and delete and seperate TUs (PR #68754)
Charlie Barto via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 16 10:19:30 PST 2023
barcharcraz wrote:
> Please elaborate, not sure I understand scope issue. Just don't put into commonly used header.
>
> Also comment duplication and STACK_TRACE macro are not addressed.
Yeah, I noticed I forgot to remove those macros, fixed that.
For the declarations of the dllexported memory functions I don't understand how moving them would reduce duplicated code at all. Each fallback works through the operator, not the associated `__asan_*` function, so the declaration only happens once.
https://github.com/llvm/llvm-project/pull/68754
More information about the llvm-commits
mailing list