[PATCH] D159283: Add intrinsic to count trailing zero elements in a vector

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 27 08:46:57 PDT 2023


kmclaughlin added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1793
+bool AArch64TargetLowering::shouldExpandCttzElements(EVT VT) const {
+  if (!Subtarget->hasSVE() || VT != MVT::nxv16i1)
+    return true;
----------------
paulwalker-arm wrote:
> Can this be `hasSVEorSME()`?
> 
> This function could be written as
> ```
> return !Subtarget->hasSVE() || VT != MVT::nxv16i1;
> ```
We can use `hasSVEorSME()` here, I've changed this and added a RUN line to `AArch64/intrinsic-cttz-elts-sve.ll`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159283/new/

https://reviews.llvm.org/D159283



More information about the llvm-commits mailing list