[llvm] [RISCV] Implement cross basic block VXRM write insertion. (PR #70382)

Roger Ferrer Ibáñez via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 23:35:54 PDT 2023


https://github.com/rofirrim commented:

LGTM. I admit dataflow isn't always my forte and I had to reach my compiler books for the anticipation part :)

The approach looks sensible to me within limits already acknowledged in the notes and fixmes.

I fail to see a test in `vxrm-insert.ll` that shows the redundant write case caused by a critical edge. If there isn't one, would it make sense to add it?

https://github.com/llvm/llvm-project/pull/70382


More information about the llvm-commits mailing list