[compiler-rt] [HWASAN] Enable memcpy, memmove and memset interceptors (PR #70387)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 26 15:52:38 PDT 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff b165650aee851b15c4f87f0d510b37cb1bf6b814 f5e83ae9a4329b74b12f3e7d00ce2db5929cbb4f -- compiler-rt/test/hwasan/TestCases/memcpy.cpp compiler-rt/test/hwasan/TestCases/memmove.cpp compiler-rt/test/hwasan/TestCases/memset.cpp compiler-rt/lib/hwasan/hwasan_interceptors.cpp compiler-rt/lib/hwasan/hwasan_platform_interceptors.h compiler-rt/test/hwasan/TestCases/bcmp.cpp compiler-rt/test/hwasan/TestCases/memcmp.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/compiler-rt/test/hwasan/TestCases/bcmp.cpp b/compiler-rt/test/hwasan/TestCases/bcmp.cpp
index 6ace21eb506f..bfc002bedac7 100644
--- a/compiler-rt/test/hwasan/TestCases/bcmp.cpp
+++ b/compiler-rt/test/hwasan/TestCases/bcmp.cpp
@@ -9,8 +9,8 @@
#include <string.h>
#include <unistd.h>
-__attribute__((no_sanitize("hwaddress")))
-int ForceCallInterceptor(void *p, const void *a, size_t size) {
+__attribute__((no_sanitize("hwaddress"))) int
+ForceCallInterceptor(void *p, const void *a, size_t size) {
return bcmp(p, a, size);
}
diff --git a/compiler-rt/test/hwasan/TestCases/memcmp.cpp b/compiler-rt/test/hwasan/TestCases/memcmp.cpp
index 6b7e86550015..d09dc4c65a34 100644
--- a/compiler-rt/test/hwasan/TestCases/memcmp.cpp
+++ b/compiler-rt/test/hwasan/TestCases/memcmp.cpp
@@ -8,8 +8,8 @@
#include <string.h>
#include <unistd.h>
-__attribute__((no_sanitize("hwaddress")))
-int ForceCalInterceptor(void *p, const void *a, size_t size) {
+__attribute__((no_sanitize("hwaddress"))) int
+ForceCalInterceptor(void *p, const void *a, size_t size) {
return memcmp(p, a, size);
}
diff --git a/compiler-rt/test/hwasan/TestCases/memcpy.cpp b/compiler-rt/test/hwasan/TestCases/memcpy.cpp
index e346409a1bd5..7d9a69196c0d 100644
--- a/compiler-rt/test/hwasan/TestCases/memcpy.cpp
+++ b/compiler-rt/test/hwasan/TestCases/memcpy.cpp
@@ -8,12 +8,11 @@
#include <string.h>
#include <unistd.h>
-__attribute__((no_sanitize("hwaddress")))
-int ForceCallInterceptor(void *p, const void *a, size_t size) {
+__attribute__((no_sanitize("hwaddress"))) int
+ForceCallInterceptor(void *p, const void *a, size_t size) {
return memcpy(p, a, size) == nullptr;
}
-
int main(int argc, char **argv) {
__hwasan_enable_allocator_tagging();
char a[] = {static_cast<char>(argc), 2, 3, 4};
@@ -30,4 +29,3 @@ int main(int argc, char **argv) {
// CHECK: previously allocated by thread
// CHECK: #{{[[:digit:]]+}} 0x{{[[:xdigit:]]+}} in main {{.*}}memcpy.cpp:[[@LINE-10]]
}
-
diff --git a/compiler-rt/test/hwasan/TestCases/memmove.cpp b/compiler-rt/test/hwasan/TestCases/memmove.cpp
index e3a3ec56aaf7..6a1acb887223 100644
--- a/compiler-rt/test/hwasan/TestCases/memmove.cpp
+++ b/compiler-rt/test/hwasan/TestCases/memmove.cpp
@@ -8,8 +8,8 @@
#include <string.h>
#include <unistd.h>
-__attribute__((no_sanitize("hwaddress")))
-int ForceCallInterceptor(void *p, const void *a, size_t size) {
+__attribute__((no_sanitize("hwaddress"))) int
+ForceCallInterceptor(void *p, const void *a, size_t size) {
return memmove(p, a, size) == nullptr;
}
@@ -29,4 +29,3 @@ int main(int argc, char **argv) {
// CHECK: previously allocated by thread
// CHECK: #{{[[:digit:]]+}} 0x{{[[:xdigit:]]+}} in main {{.*}}memmove.cpp:[[@LINE-10]]
}
-
diff --git a/compiler-rt/test/hwasan/TestCases/memset.cpp b/compiler-rt/test/hwasan/TestCases/memset.cpp
index 5ebe2fbad407..3006b04998e3 100644
--- a/compiler-rt/test/hwasan/TestCases/memset.cpp
+++ b/compiler-rt/test/hwasan/TestCases/memset.cpp
@@ -8,8 +8,8 @@
#include <string.h>
#include <unistd.h>
-__attribute__((no_sanitize("hwaddress")))
-int ForceCallInterceptor(void *p, int c, size_t size) {
+__attribute__((no_sanitize("hwaddress"))) int
+ForceCallInterceptor(void *p, int c, size_t size) {
return memset(p, c, size) == nullptr;
}
@@ -29,4 +29,3 @@ int main(int argc, char **argv) {
// CHECK: previously allocated by thread
// CHECK: #{{[[:digit:]]+}} 0x{{[[:xdigit:]]+}} in main {{.*}}memset.cpp:[[@LINE-10]]
}
-
``````````
</details>
https://github.com/llvm/llvm-project/pull/70387
More information about the llvm-commits
mailing list