[PATCH] D141060: [opt] Infer DataLayout from triple if not specified

Thu Oct 26 14:41:37 PDT 2023

dyung added a comment.

In D141060#4655317 <https://reviews.llvm.org/D141060#4655317>, @arichardson wrote:

> In D141060#4655314 <https://reviews.llvm.org/D141060#4655314>, @dyung wrote:
>
>> @arichardson, your commit is causing 9 failures on the PS4 linux bot (https://lab.llvm.org/buildbot/#/builders/139/builds/52287), and 10 failures on the PS5 Windows bot (https://lab.llvm.org/buildbot/#/builders/216/builds/29384). The extra Windows failure is because the test `llvm/test/tools/opt/invalid-target.ll` is not accounting for Windows executables, it is checing for opt not opt.exe which is what appears in the warning message on Windows.
>>
>> Can you please take a look and revert if you need time to investigate?
>
> Those should hopefully be fixed now, and about to push the windows build fix.

Thanks! Looks like you may need to update one additional test? https://lab.llvm.org/buildbot/#/builders/139/builds/52298

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141060/new/

https://reviews.llvm.org/D141060