[llvm] [Linker] Do not keep a private member of a non-prevailing comdat group (PR #69143)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 14:39:36 PDT 2023


================
@@ -473,6 +474,9 @@ bool ModuleLinker::run() {
       return true;
     ComdatsChosen[&C] = std::make_pair(SK, From);
 
+    if (From == LinkFrom::Dst)
----------------
rnk wrote:

I think for COFF (not for ELF) in the comdat-refer-to-discarded.ll test case we should get a result of `LinkFrom::Both` here.

https://github.com/llvm/llvm-project/pull/69143


More information about the llvm-commits mailing list