[llvm] [llvm][AArch64][Assembly]: Add FP8FMA assembly and disassembly. (PR #70134)

Lucas Duarte Prates via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 02:57:57 PDT 2023


================
@@ -6055,6 +6055,15 @@ multiclass SIMDThreeSameVectorFML<bit U, bit b13, bits<3> size, string asm,
                                          v4f32, v8f16, OpNode>;
 }
 
+multiclass SIMDThreeSameVectorMLA<bit Q, string asm>{
----------------
pratlucas wrote:

An alternative would be to define a new class which inherits from `BaseSIMDThreeSameVectorDot` and handles the common values for all the definitions. For example:
```
class SIMDThreeSameVectorMLA<bit Q, string asm>
    : BaseSIMDThreeSameVectorDot<Q, 0b0, 0b11, 0b1111, asm, ".8h", ".16b",
                                                              V128, v8f16, v16i8, null_frag>;
```
Using multiclasses for consistency sounds reasonable, though, if you prefer to keep the current implementation.

https://github.com/llvm/llvm-project/pull/70134


More information about the llvm-commits mailing list