[PATCH] D149918: [InstCombine] Add oneuse checks to shr + cmp constant folds.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 02:40:00 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/InstCombine/ashr-icmp-minmax-idiom-break.ll:4
 
 ; This test is pre-committed to show sub-optimal codegen due to
 ; min/max idiom breakage. On AArch64, these constants are also expensive to materialize,
----------------
Adjust comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149918/new/

https://reviews.llvm.org/D149918



More information about the llvm-commits mailing list