[llvm] [AMDGPU] Improve isBasicBlockPrologue helper function (PR #69924)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 25 19:24:57 PDT 2023


================
@@ -8335,8 +8335,14 @@ unsigned SIInstrInfo::getLiveRangeSplitOpcode(Register SrcReg,
 }
 
 bool SIInstrInfo::isBasicBlockPrologue(const MachineInstr &MI) const {
-  return !MI.isTerminator() && MI.getOpcode() != AMDGPU::COPY &&
-         MI.modifiesRegister(AMDGPU::EXEC, &RI);
+  // It should cover all possible instructions inserted during regalloc in the
+  // block prolog.
----------------
arsenm wrote:

This should elaborate on why. It's still a pretty dicey assumption

https://github.com/llvm/llvm-project/pull/69924


More information about the llvm-commits mailing list