[PATCH] D152928: [RFC][DAG] Initially add nodes in the worklist in topological order.

Wed Oct 25 09:03:59 PDT 2023

RKSimon added a comment.

In D152928#4654641 <https://reviews.llvm.org/D152928#4654641>, @deadalnix wrote:

> In D152928#4654624 <https://reviews.llvm.org/D152928#4654624>, @RKSimon wrote:
>
>> Given that this is not going to be resolved anytime soon and we're relatively early into the review, would you be open to moving this to a GitHub PR?
>
> If this is what it takes, but I'm really not thrilled by the move to be honest. It's way harder to keep track of changes, notification are basically useless, and there is no kind of useful dashboard of what one need to pay attention to either.

Yes its as much fun as a tooth extraction :| But I'm worried that Phab will not get much love going forward and we're months away from getting the x86 regressions fixed, let alone any other backend.

I've started my own WIP branch of this patch at https://github.com/RKSimon/llvm-project/tree/perf/D152928 so I can more easily work though addressing issues; I'll be rebasing + forcing pushes so don't rely on git history if you track it. But wherever you decide to keep the main patch will remain the reference.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152928/new/

https://reviews.llvm.org/D152928