[PATCH] D158511: [AArch64] Move SLS later in pass pipeline

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:225-226
       MF.getSubtarget<AArch64Subtarget>().getInstrInfo();
-  assert (MF.size() == 1);
+  assert (MF.size() == 0);
+  MF.push_back(MF.CreateMachineBasicBlock());
   MachineBasicBlock *Entry = &MF.front();
----------------
olista01 wrote:
> kristof.beyls wrote:
> > I guess this change is a side-effect of moving the AArch64IndirectThunks pass later in the pipeline. But I cannot easily guess what exactly triggers this change in behavior. I wonder if you happen to know?
> IndirectThunks.h:84 has a comment explaining that it does not create the entry block, but I've not worked out where it was being created before.
Thanks. I guess it doesn't really matter much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158511/new/

https://reviews.llvm.org/D158511