[llvm] [ARM, ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR #70014)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 19:43:43 PDT 2023


================
@@ -2019,7 +2019,9 @@ void TargetLoweringBase::insertSSPDeclarations(Module &M) const {
     if (M.getDirectAccessExternalData() &&
         !TM.getTargetTriple().isWindowsGNUEnvironment() &&
         !TM.getTargetTriple().isOSFreeBSD() &&
-        !TM.getTargetTriple().isOSDarwin())
+        (!TM.getTargetTriple().isOSDarwin() ||
+         (TM.getTargetTriple().isARM() &&
----------------
MaskRay wrote:

This ensures that code generation for arm*-apple-darwin -fno-pic does not change.

If `arm*-apple-darwin -fno-pic` is ok to use indirection, we can clean up this afterwards.

https://github.com/llvm/llvm-project/pull/70014


More information about the llvm-commits mailing list